-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize const_float_classify
#130157
Stabilize const_float_classify
#130157
Conversation
☔ The latest upstream changes (presumably #130253) made this pull request unmergeable. Please resolve the merge conflicts. |
3e1c8ad
to
e071950
Compare
I think libs-api needs to handle these? |
Cc @rust-lang/wg-const-eval -- this is entirely harmless, the methods just all use already-stable const facilities. (Team pings only work when an org member writes them, AFAIK.) |
Nit: could you put this PR link and/or the relevant commit SHAs in that commit message? It's currently just a title so no crosslinking. |
The PR link is in the PR description which bors will put into the merge commit message. So I think that will be covered. |
… context" Reverts PR rust-lang#114486 (commit 1305a43)
e071950
to
c39ae56
Compare
☀️ Test successful - checks-actions |
Finished benchmarking commit (14f303b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.465s -> 771.36s (-0.01%) |
…llogiq Cleanup `const_float_classify` As mentioned at #13508 `const_float_classify` has been stabilized recently in rust-lang/rust#130157 and can be cleanup Close #13508 changelog: [none]
Tracking issue: #72505
Also reverts #114486
Closes #72505
Stabilized const API:
cc @rust-lang/wg-const-eval @rust-lang/libs-api